rreddy-22 commented on code in PR #16504:
URL: https://github.com/apache/kafka/pull/16504#discussion_r1663537165
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java:
##########
@@ -730,7 +922,20 @@ private void assertAssignment(
assertEquals(expectedAssignment.size(),
computedGroupAssignment.members().size());
for (String memberId : computedGroupAssignment.members().keySet()) {
Map<Uuid, Set<Integer>> computedAssignmentForMember =
computedGroupAssignment.members().get(memberId).partitions();
- assertEquals(expectedAssignment.get(memberId),
computedAssignmentForMember);
+ Map<Uuid, Set<Integer>> expectedAssignmentForMember =
expectedAssignment.get(memberId);
+
+ // Compare the content of the maps by entries.
+ assertEquals(expectedAssignmentForMember.size(),
computedAssignmentForMember.size());
+ for (Map.Entry<Uuid, Set<Integer>> entry :
expectedAssignmentForMember.entrySet()) {
+ Set<Integer> expectedSet = entry.getValue();
+ Set<Integer> computedSet =
computedAssignmentForMember.get(entry.getKey());
+
+ // Convert both sets to HashSet for comparison.
+ Set<Integer> normalizedExpectedSet = new
HashSet<>(expectedSet);
+ Set<Integer> normalizedComputedSet = new
HashSet<>(computedSet);
+
+ assertEquals(normalizedExpectedSet, normalizedComputedSet);
+ }
Review Comment:
yeah, I think it didn't work initially, but changed it now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
