[
https://issues.apache.org/jira/browse/KAFKA-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16596480#comment-16596480
]
ASF GitHub Bot commented on KAFKA-7354:
---------------------------------------
lindong28 closed pull request #5584: KAFKA-7354: Fix IdlePercent and
NetworkProcessorAvgIdlePercent metric
URL: https://github.com/apache/kafka/pull/5584
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/scala/kafka/network/SocketServer.scala
b/core/src/main/scala/kafka/network/SocketServer.scala
index 749c921ee02..96feee89003 100644
--- a/core/src/main/scala/kafka/network/SocketServer.scala
+++ b/core/src/main/scala/kafka/network/SocketServer.scala
@@ -102,7 +102,7 @@ class SocketServer(val config: KafkaConfig, val metrics:
Metrics, val time: Time
metrics.metricName("io-wait-ratio", "socket-server-metrics",
p.metricTags)
}
ioWaitRatioMetricNames.map { metricName =>
- Option(metrics.metric(metricName)).fold(0.0)(_.value)
+ Option(metrics.metric(metricName)).fold(0.0)(m =>
Math.min(m.metricValue.asInstanceOf[Double], 1.0))
}.sum / processors.size
}
}
@@ -538,7 +538,8 @@ private[kafka] class Processor(val id: Int,
newGauge(IdlePercentMetricName,
new Gauge[Double] {
def value = {
- Option(metrics.metric(metrics.metricName("io-wait-ratio",
"socket-server-metrics", metricTags))).fold(0.0)(_.value)
+ Option(metrics.metric(metrics.metricName("io-wait-ratio",
"socket-server-metrics", metricTags)))
+ .fold(0.0)(m => Math.min(m.metricValue.asInstanceOf[Double], 1.0))
}
},
// for compatibility, only add a networkProcessor tag to the Yammer
Metrics alias (the equivalent Selector metric
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix IdlePercent and NetworkProcessorAvgIdlePercent metric calculation
> ---------------------------------------------------------------------
>
> Key: KAFKA-7354
> URL: https://issues.apache.org/jira/browse/KAFKA-7354
> Project: Kafka
> Issue Type: Bug
> Components: core
> Affects Versions: 2.0.0
> Reporter: huxihx
> Assignee: huxihx
> Priority: Major
>
> Currently, MBean
> `kafka.network:type=Processor,name=IdlePercent,networkProcessor=*` and
> `afka.network:type=SocketServer,name=NetworkProcessorAvgIdlePercent` could be
> greater than 1. However, these two values represent a percentage which should
> not exceed 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
