chia7712 commented on PR #16458: URL: https://github.com/apache/kafka/pull/16458#issuecomment-2206822223
I double-check all configs and yes all of them are not dynamic. Maybe we don't need to be over-engineering for now. Hence, we can have a PR for following changes. 1. re-introduce attributes to `GroupCoordinatorConfig` @dajac [comment](https://github.com/apache/kafka/pull/16458#discussion_r1662130270) 2. move `GroupCoordinatorConfig` validation from `KafkaConfig` to `GroupCoordinatorConfig` ( @OmniaGM [comment](https://github.com/apache/kafka/pull/16458#discussion_r1662318237)) 3. do validation in construction of `GroupCoordinatorConfig`. I guess this is a bit different to @OmniaGM idea (#16506 add a method `validate` to `ShareGroupConfig` instead of validating configs in construction). I prefer to validate all configs in construction as `KafakConfig` do validation in construction too. 4. add docs to `GroupCoordinatorConfig` to explain why we add attributes @brandboat @dajac @OmniaGM PTAL, I hope this can be a guideline for all similar config class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
