sjhajharia commented on code in PR #16363:
URL: https://github.com/apache/kafka/pull/16363#discussion_r1666349744
##########
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##########
@@ -154,7 +154,9 @@ public void connecting(String id, long now, String host) {
connectingNodes.add(id);
return;
} else if (connectionState != null) {
- log.info("Hostname for node {} changed from {} to {}.", id,
connectionState.host(), host);
+ if (log.isInfoEnabled()){
Review Comment:
There must be a space before the braces here as per the checkstyle
##########
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##########
@@ -463,7 +465,7 @@ public List<String> nodesWithConnectionSetupTimeout(long
now) {
/**
* The state of our connection to a node.
*/
- private static class NodeConnectionState {
+ private final static class NodeConnectionState {
Review Comment:
I guess the order here must be `static final`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
