FrankYang0529 commented on code in PR #16449:
URL: https://github.com/apache/kafka/pull/16449#discussion_r1667008009
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##########
@@ -687,7 +687,6 @@ public CompletableFuture<Void> leaveGroup() {
"to clear its assignment and send a leave group
heartbeat", memberId);
}
// Clear the subscription, no matter if the callback execution
failed or succeeded.
- subscriptions.unsubscribe();
Review Comment:
Okay. I revert the change in `MembershipManagerImpl.java#leaveGroup` and
call `subscriptions.unsubscribe()` directly in
`ApplicationEventProcessor#process` if `heartbeatRequestManager` is not present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
