chia7712 commented on code in PR #16532:
URL: https://github.com/apache/kafka/pull/16532#discussion_r1667176539
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java:
##########
@@ -3665,6 +3670,52 @@ public void
testWhenFetchResponseReturnsALeaderShipChangeErrorAndNewLeaderInform
// Validate subscription is still valid & fetch-able for tp1.
assertTrue(subscriptions.isFetchable(tp1));
}
+
+ @Test
+ public void testFetcherDontCacheAnyData() {
Review Comment:
This part is good but it's gone too far. Maybe we can create a
`FetchResponse` and then test the method `responseData`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]