DL1231 commented on code in PR #15067:
URL: https://github.com/apache/kafka/pull/15067#discussion_r1667622457


##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -13426,6 +13429,99 @@ public void 
testNoConversionWhenSizeExceedsClassicMaxGroupSize() throws Exceptio
         assertEquals(Group.GroupType.CONSUMER, 
context.groupMetadataManager.group(groupId).type());
     }
 
+    @Test
+    public void testDynamicUpdateSessionTimeout() {
+        String groupId = "fooup";
+        // Use a static member id as it makes the test easier.
+        String memberId = Uuid.randomUuid().toString();
+
+        Uuid fooTopicId = Uuid.randomUuid();
+        String fooTopicName = "foo";
+        GroupConfigManager configManager = createConfigManager();

Review Comment:
   Done.



##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -13426,6 +13429,99 @@ public void 
testNoConversionWhenSizeExceedsClassicMaxGroupSize() throws Exceptio
         assertEquals(Group.GroupType.CONSUMER, 
context.groupMetadataManager.group(groupId).type());
     }
 
+    @Test
+    public void testDynamicUpdateSessionTimeout() {

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to