FrankYang0529 commented on code in PR #16499:
URL: https://github.com/apache/kafka/pull/16499#discussion_r1668414811
##########
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##########
@@ -82,7 +84,9 @@
* SomeIntegrationTest will be instantiated, lifecycle methods (before/after)
will be run, and "someTest" will be invoked.
*
*/
-public class ClusterTestExtensions implements
TestTemplateInvocationContextProvider {
+public class ClusterTestExtensions implements
TestTemplateInvocationContextProvider, BeforeEachCallback, AfterEachCallback {
Review Comment:
It looks like we need to add detection to `ClusterTestExtensions`. I try to
make leak thread and use detection in `RaftClusterInvocationContext` and
`ZkClusterInvocationContext`, only detection in `ClusterTestExtensions` can
work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
