C0urante commented on PR #16486: URL: https://github.com/apache/kafka/pull/16486#issuecomment-2214494017
Most of our CI failures are flaky tests that can be ignored, but there are a few failures that are happening because this PR directly causes them. You can find those in the `RebalanceSourceConnectorsIntegrationTest` and `IncrementalCooperativeAssignorTest` test suites, and I'd strongly suggest running those test suites locally before pushing another commit, as it's much faster to run tests locally than to wait for CI to do them. This PR might be acceptable (once the test failures are addressed) as-is, but there's an open question (that I raised [here](https://github.com/apache/kafka/pull/16486#discussion_r1661291768)) that would have to be settled on first. Essentially, we might have to do an additional round of revocations if we want to fully address the goal of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
