chia7712 commented on PR #12148: URL: https://github.com/apache/kafka/pull/12148#issuecomment-2214584773
> Remove log4j-appender dependency from tools, trogdor and shell After addressing that, the distribution does not include log4j-appender jar anymore. ``` chia7712@ubuntu00:~/project/kafka/core/build/distributions$ ls kafka_2.13-3.9.0-SNAPSHOT/libs | grep kafka kafka_2.13-3.9.0-SNAPSHOT.jar kafka-clients-3.9.0-SNAPSHOT.jar kafka-group-coordinator-3.9.0-SNAPSHOT.jar kafka-group-coordinator-api-3.9.0-SNAPSHOT.jar kafka-metadata-3.9.0-SNAPSHOT.jar kafka-raft-3.9.0-SNAPSHOT.jar kafka-server-3.9.0-SNAPSHOT.jar kafka-server-common-3.9.0-SNAPSHOT.jar kafka-shell-3.9.0-SNAPSHOT.jar kafka-storage-3.9.0-SNAPSHOT.jar kafka-storage-api-3.9.0-SNAPSHOT.jar kafka-streams-3.9.0-SNAPSHOT.jar kafka-streams-examples-3.9.0-SNAPSHOT.jar kafka-streams-scala_2.13-3.9.0-SNAPSHOT.jar kafka-streams-test-utils-3.9.0-SNAPSHOT.jar kafka-tools-3.9.0-SNAPSHOT.jar kafka-tools-api-3.9.0-SNAPSHOT.jar kafka-transaction-coordinator-3.9.0-SNAPSHOT.jar ``` 1. not sure whether it is expected? `KafkaLog4jAppender` is deprecated now, but we should keep it in release? 2. For another, the system test `kafka_log4j_appender.py` gets failed due to same reason. Hence, we have following approaches to fix above issues. 1. add `log4j-appender` dependency to core module. this can fix issue_1 and issue_2 2. add `log4j-appender` dependency to `copyDependantTestLibs`, and then make `kafka_log4j_appender.py` expose new classpath to include to `log4j-appender` jar. this can fix issue_2. @ijuma WDYT? I prefer approach_1 as it keep the compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
