cmccabe commented on code in PR #16421:
URL: https://github.com/apache/kafka/pull/16421#discussion_r1671022232
##########
clients/src/main/java/org/apache/kafka/common/requests/BrokerRegistrationRequest.java:
##########
@@ -45,7 +46,21 @@ public short oldestAllowedVersion() {
@Override
public BrokerRegistrationRequest build(short version) {
- return new BrokerRegistrationRequest(data, version);
+ if (version < 4) {
+ // Workaround for KAFKA-17011: for BrokerRegistrationRequest
versions older than 4,
+ // exclude support version ranges that begin with 0.
+ BrokerRegistrationRequestData newData = data.duplicate();
+ for (Iterator<BrokerRegistrationRequestData.Feature> iter =
newData.features().iterator();
Review Comment:
As discussed, we'll change this to match ApiVersionsResponse (rather than
excluding, we'll set it to minSupportedVersion = 1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
