OmniaGM commented on PR #16506: URL: https://github.com/apache/kafka/pull/16506#issuecomment-2220229776
> lgtm. I was wondering how the refactoring that @OmniaGM is doing for config would affect the work we are doing on KIP-932. @AndrewJSchofield I believe it shouldn't have significant effect on KIP-932's work apart from the fact that now all getters, validation and config definitions will be defined in `ShareGroupConfig`. Specially that as far as I can see we still didn't define all broker configs defined in KIP-932 yet. This also should reduce conflicts between refactoring `KafkaConfig` and broker config part of KIP-932. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
