mumrah commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1672730022
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -500,9 +631,26 @@ boolean uncleanLeaderElectionEnabledForTopic(String name) {
return false; // TODO: support configuring unclean leader election.
}
+ Map<String, ConfigEntry> computeEffectiveTopicConfigsWithPendingChange(
+ Map<ConfigResource, Map<String, String>> pendingConfigData
+ ) {
+ Map<String, String> pendingClusterConfig =
+ pendingConfigData.containsKey(DEFAULT_NODE) ?
pendingConfigData.get(DEFAULT_NODE) : Collections.emptyMap();
+ Map<String, String> pendingControllerConfig =
+ pendingConfigData.containsKey(currentController) ?
pendingConfigData.get(currentController) : Collections.emptyMap();
+ return configSchema.resolveEffectiveTopicConfigs(
+ new OrderedConfigResolver(staticConfig),
Review Comment:
Hm.. what happens if the controller has different static configs from the
broker?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
