jsancio commented on code in PR #16230:
URL: https://github.com/apache/kafka/pull/16230#discussion_r1674397738
##########
clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java:
##########
@@ -313,10 +313,12 @@ private static FinalizedFeatureKeyCollection
createFinalizedFeatureKeys(
for (Map.Entry<String, Short> feature : finalizedFeatures.entrySet()) {
final FinalizedFeatureKey key = new FinalizedFeatureKey();
final short versionLevel = feature.getValue();
- key.setName(feature.getKey());
- key.setMinVersionLevel(versionLevel);
- key.setMaxVersionLevel(versionLevel);
- converted.add(key);
+ if (versionLevel != 0) {
Review Comment:
The indentation seems off. I think you need to remove 4 spaces.
Let's write comment explaining why we only do this when the version level is
not 0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
