chia7712 commented on code in PR #16566:
URL: https://github.com/apache/kafka/pull/16566#discussion_r1675650343
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1572,10 +1564,10 @@ public void
testManualAssignmentChangeWithAutoCommitEnabled(GroupProtocol groupP
ConsumerPartitionAssignor assignor = new RangeAssignor();
+
client.prepareResponseFrom(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, node), node);
Review Comment:
Why return a non-controller node in `FindCoordinatorResponse`? Is that
expected?
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1629,10 +1619,10 @@ public void
testManualAssignmentChangeWithAutoCommitDisabled(GroupProtocol group
ConsumerPartitionAssignor assignor = new RangeAssignor();
+
client.prepareResponseFrom(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, node), node);
Review Comment:
ditto
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1684,10 +1672,10 @@ public void testOffsetOfPausedPartitions(GroupProtocol
groupProtocol) {
ConsumerPartitionAssignor assignor = new RangeAssignor();
+
client.prepareResponseFrom(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, node), node);
Review Comment:
ditto
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1898,9 +1884,9 @@ public void
testShouldAttemptToRejoinGroupAfterSyncGroupFailed(GroupProtocol gro
initMetadata(client, Collections.singletonMap(topic, 1));
Node node = metadata.fetch().nodes().get(0);
+
client.prepareResponseFrom(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, node), node);
Review Comment:
ditto
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -1077,22 +1073,20 @@ public void
testFetchStableOffsetThrowInPosition(GroupProtocol groupProtocol) {
Node node = metadata.fetch().nodes().get(0);
+
client.prepareResponseFrom(FindCoordinatorResponse.prepareResponse(Errors.NONE,
groupId, node), node);
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
