brandboat commented on code in PR #16592:
URL: https://github.com/apache/kafka/pull/16592#discussion_r1678099454
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java:
##########
@@ -74,37 +71,10 @@ public class ProducerStateManager {
public static final long LATE_TRANSACTION_BUFFER_MS = 5 * 60 * 1000;
- private static final short PRODUCER_SNAPSHOT_VERSION = 1;
Review Comment:
> @brandboat could you add a temporary unit test to verify the
compatibility? We can move those struct stuff to testing and then generate some
random data for comparison.
Thanks, indeed there should have a compatibility test. One thing need to be
mentioned is the unit test for ProducerStateManager is in scala, so I have to
convert all old implementation in java code to scala code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
