loicgreffier commented on code in PR #16093:
URL: https://github.com/apache/kafka/pull/16093#discussion_r1678168437
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java:
##########
@@ -174,6 +199,32 @@ public void process(final Record<KIn, VIn> record) {
keyClass,
valueClass),
e);
+ } catch (final FailedProcessingException | TaskCorruptedException e) {
Review Comment:
Exceptions with a special treatment in the `StreamThread` have been ignored:
https://github.com/apache/kafka/blob/dceda5e647cf44226c2be5e148e0be60ce665db9/streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java#L722
`TaskMigratedException` (added to ignore) and `TaskCorruptedException` have
been ignored. I believe users won't expect these exceptions to be handled,
that's why they're just rethrown as is.
`UnsupportedVersionException` should not need to be ignored as it cannot be
thrown during process.
I've added a `@ParameterizedTest` that asserts `FailedProcessingException`,
`TaskCorruptedException` and `TaskMigratedException` are ignored on purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
