[
https://issues.apache.org/jira/browse/KAFKA-17145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17866449#comment-17866449
]
Chris Egerton commented on KAFKA-17145:
---------------------------------------
IMO this does not warrant a new RC, nor should it be reverted. The method in
question is trivial and can and should be implemented without relying on Kafka
libraries. We should not establish the precedent of accommodating every
connector that incorrectly relies on private APIs; it's already bad enough with
the {{KafkaBasedLog}} class, which Confluent should have stopped using years
ago or, if they truly could not implement something like it on their own,
published a KIP to make it public.
Please fix your connector, don't make it the problem of the Kafka Connect
maintainers, and do a preemptive scan of any other connectors that rely on
internal Kafka APIs so that you won't have to worry about this happening again
when we continue to make changes to our internal APIs.
Closing as won't fix.
> Reinstate Utils.join() method in org.apache.kafka.common.utils
> --------------------------------------------------------------
>
> Key: KAFKA-17145
> URL: https://issues.apache.org/jira/browse/KAFKA-17145
> Project: Kafka
> Issue Type: Bug
> Components: connect
> Affects Versions: 3.8.0
> Reporter: Vikas Balani
> Assignee: Vikas Balani
> Priority: Major
>
> h3. Description:
> The Utils.join() function has been removed from the
> org.apache.kafka.common.utils package. This utility function is widely used
> by many connector plugins, which are now failing due to the absence of this
> method.
> h3. Example of affected code:
> The S3 Sink Connector uses this method here:
> [link|https://github.com/confluentinc/kafka-connect-storage-cloud/blob/c90780dd61c6b1e11cd89c20619ac81a99aa19d5/kafka-connect-s3/src/main/java/io/confluent/connect/s3/S3SinkConnectorConfig.java#L1087]
> h3. Impact:
> 1. Connector plugins that depend on this method are failing.
> 2. This change breaks backward compatibility for plugins and custom code
> relying on Utils.join().
> h3. Proposed Solution:
> 1. Partially revert https://github.com/apache/kafka/pull/15823
> 2. Restore the Utils.join() method in org.apache.kafka.common.utils.
> 3. Maintain the usage of JDK API within Apache Kafka codebase instead of
> Utils.join().
> 4. Add a deprecation warning to Utils.join() to indicate future removal.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
