chia7712 commented on code in PR #16499: URL: https://github.com/apache/kafka/pull/16499#discussion_r1681973330
########## core/src/test/java/kafka/test/junit/DetectThreadLeakTest.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.test.junit; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class DetectThreadLeakTest { + + private static class LeakThread implements Runnable { + @Override + public void run() { + try { + Thread.sleep(20000); + } catch (InterruptedException e) { + // this can be neglected + } + } + } + + @Test + public void testThreadLeak() throws InterruptedException { + DetectThreadLeak detectThreadLeak = DetectThreadLeak.of(thread -> true); + Thread leakThread = new Thread(new LeakThread()); + leakThread.start(); + assertTrue(detectThreadLeak.newThreads().contains(leakThread)); + leakThread.interrupt(); + leakThread.join(); + assertFalse(leakThread.isAlive(), "Can't interrupt the thread"); + assertFalse(detectThreadLeak.newThreads().contains(leakThread)); + } + + @Test + public void testDetectThreadLeakWithOverrideExpectedThreadNames() throws InterruptedException { + String threadName = "test-thread"; + DetectThreadLeak detectThreadLeak = DetectThreadLeak.of(thread -> !thread.getName().equals(threadName)); + Thread leakThread = new Thread(new LeakThread(), threadName); + leakThread.start(); + assertFalse(detectThreadLeak.newThreads().contains(leakThread)); + leakThread.interrupt(); + leakThread.join(); Review Comment: ditto ########## core/src/test/java/kafka/test/junit/DetectThreadLeakTest.java: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package kafka.test.junit; + +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class DetectThreadLeakTest { + + private static class LeakThread implements Runnable { + @Override + public void run() { + try { + Thread.sleep(20000); + } catch (InterruptedException e) { + // this can be neglected + } + } + } + + @Test + public void testThreadLeak() throws InterruptedException { + DetectThreadLeak detectThreadLeak = DetectThreadLeak.of(thread -> true); + Thread leakThread = new Thread(new LeakThread()); + leakThread.start(); + assertTrue(detectThreadLeak.newThreads().contains(leakThread)); + leakThread.interrupt(); + leakThread.join(); Review Comment: How about moving it to finally block? ########## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ########## @@ -119,7 +139,27 @@ public Stream<TestTemplateInvocationContext> provideTestTemplateInvocationContex return generatedContexts.stream(); } + @Override + public void beforeEach(ExtensionContext context) { + DetectThreadLeak detectThreadLeak = DetectThreadLeak.of(thread -> + SKIPPED_THREAD_PREFIX.stream().noneMatch(prefix -> thread.getName().startsWith(prefix))); + getStore(context).put(DETECT_THREAD_LEAK_KEY, detectThreadLeak); + } + + @Override + public void afterEach(ExtensionContext context) throws InterruptedException { + DetectThreadLeak detectThreadLeak = getStore(context).remove(DETECT_THREAD_LEAK_KEY, DetectThreadLeak.class); + if (detectThreadLeak == null) { + return; + } + TestUtils.waitForCondition(() -> detectThreadLeak.newThreads().isEmpty(), + "Thread leak detected: " + + detectThreadLeak.newThreads().stream().map(Thread::getName).collect(Collectors.joining(", "))); + } + private Store getStore(ExtensionContext context) { + return context.getStore(Namespace.create(getClass(), context.getRequiredTestMethod())); Review Comment: That will be duplicate if the method is parameterized. If you try to create unique namespace for each test instance, please consider using `getUniqueId` instead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
