FrankYang0529 commented on code in PR #16614:
URL: https://github.com/apache/kafka/pull/16614#discussion_r1682150630


##########
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##########
@@ -957,6 +957,17 @@ class LogManagerTest {
       val topicPartition = UnifiedLog.parseTopicPartitionName(dir)
       val config = topicConfigOverrides.getOrElse(topicPartition.topic, 
logConfig)
 
+      if (dir == logDir2) {

Review Comment:
   Yes, I tried another to get `epochs.values()` in the write lock, so we don't 
need to get read lock again to get the value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to