lianetm commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1683353250
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -621,7 +628,6 @@ public void testPollTimerExpiration() {
assertHeartbeat(heartbeatRequestManager,
DEFAULT_HEARTBEAT_INTERVAL_MS);
verify(membershipManager).transitionToSendingLeaveGroup(true);
verify(heartbeatState).reset();
- verify(heartbeatRequestState).reset();
verify(membershipManager).onHeartbeatRequestSent();
when(membershipManager.state()).thenReturn(MemberState.STALE);
Review Comment:
maybe no needed anymore? (the following expectation on `shouldSkipHeartbeat`
is probably all we need)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
