C0urante commented on code in PR #16647:
URL: https://github.com/apache/kafka/pull/16647#discussion_r1685806406
##########
connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java:
##########
@@ -520,17 +543,6 @@ public byte[] fromConnectHeader(String topic, String
headerKey, Schema schema, O
public abstract static class AbstractTestConverter extends TestConverter {
}
- public static class TestConverterWithPrivateConstructor extends
TestConverter {
- private TestConverterWithPrivateConstructor() {
- }
- }
-
- public static class TestConverterWithConstructorThatThrowsException
extends TestConverter {
- public TestConverterWithConstructorThatThrowsException() {
- throw new ConnectException("whoops");
- }
- }
-
public static class TestConverterWithSinglePropertyConfigDef extends
TestConverter {
Review Comment:
This and the other plugin classes below it seem fine to leave in for now,
since (being valid plugins that can be successfully instantiated via a public,
no-args constructor) they don't generate any abnormal log messages on worker
startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
