mimaison commented on code in PR #16655:
URL: https://github.com/apache/kafka/pull/16655#discussion_r1686579429
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java:
##########
@@ -58,15 +58,12 @@ public class WorkerConfig extends AbstractConfig {
private static final Logger log =
LoggerFactory.getLogger(WorkerConfig.class);
public static final String BOOTSTRAP_SERVERS_CONFIG = "bootstrap.servers";
- public static final String BOOTSTRAP_SERVERS_DOC
Review Comment:
Since it's the same doc than `CommonClientConfigs`, I think we could reuse
`CommonClientConfigs.BOOTSTRAP_SERVERS_DOC` (and do the same for
`BOOTSTRAP_SERVERS_CONFIG` above).
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -45,11 +45,11 @@ public class CommonClientConfigs {
*/
public static final String BOOTSTRAP_SERVERS_CONFIG = "bootstrap.servers";
- public static final String BOOTSTRAP_SERVERS_DOC = "A list of host/port
pairs to use for establishing the initial connection to the Kafka cluster. The
client will make use of all servers irrespective of which servers are specified
here for bootstrapping—this list only impacts the initial hosts used to
discover the full set of servers. This list should be in the form "
- +
"<code>host1:port1,host2:port2,...</code>. Since these servers are just used
for the initial connection to "
- + "discover the full
cluster membership (which may change dynamically), this list need not contain
the full set of "
- + "servers (you may
want more than one, though, in case a server is down).";
Review Comment:
Is it really important to mention clients randomly pick an entry in the list
when first bootstrapping?
##########
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##########
@@ -45,11 +45,11 @@ public class CommonClientConfigs {
*/
public static final String BOOTSTRAP_SERVERS_CONFIG = "bootstrap.servers";
- public static final String BOOTSTRAP_SERVERS_DOC = "A list of host/port
pairs to use for establishing the initial connection to the Kafka cluster. The
client will make use of all servers irrespective of which servers are specified
here for bootstrapping—this list only impacts the initial hosts used to
discover the full set of servers. This list should be in the form "
- +
"<code>host1:port1,host2:port2,...</code>. Since these servers are just used
for the initial connection to "
- + "discover the full
cluster membership (which may change dynamically), this list need not contain
the full set of "
- + "servers (you may
want more than one, though, in case a server is down).";
Review Comment:
I wonder if we could just change `you may want` to `we recommend using`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
