chia7712 commented on code in PR #16648:
URL: https://github.com/apache/kafka/pull/16648#discussion_r1686724598
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2432,12 +2628,12 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
}
/**
- * 1. Assume ROOT logger == TRACE
- * 2. Change kafka.controller.KafkaController logger to INFO
- * 3. Unset kafka.controller.KafkaController via
AlterConfigOp.OpType.DELETE (resets it to the root logger - TRACE)
- * 4. Change ROOT logger to ERROR
- * 5. Ensure the kafka.controller.KafkaController logger's level is ERROR
(the current root logger level)
- */
+ * 1. Assume ROOT logger == TRACE
Review Comment:
please remove unrelated changes
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2720,11 +2917,11 @@ object PlaintextAdminIntegrationTest {
@nowarn("cat=deprecation")
def checkValidAlterConfigs(
- admin: Admin,
- test: KafkaServerTestHarness,
- topicResource1: ConfigResource,
- topicResource2: ConfigResource
- ): Unit = {
+ admin: Admin,
Review Comment:
ditto
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2790,9 +2987,9 @@ object PlaintextAdminIntegrationTest {
@nowarn("cat=deprecation")
def checkInvalidAlterConfigs(
- test: KafkaServerTestHarness,
- admin: Admin
- ): Unit = {
+ test: KafkaServerTestHarness,
Review Comment:
ditto
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -6,7 +6,7 @@
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
Review Comment:
ditto
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -2500,6 +2696,7 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
client = createAdminClient
val validLoggerName = "kafka.server.KafkaRequestHandler"
val expectedValidLoggerLogLevel =
describeBrokerLoggers().get(validLoggerName)
+
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
