satishd commented on code in PR #16657:
URL: https://github.com/apache/kafka/pull/16657#discussion_r1686938593
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteStorageThreadPool.java:
##########
@@ -34,7 +34,7 @@
import static
org.apache.kafka.server.log.remote.storage.RemoteStorageMetrics.REMOTE_STORAGE_THREAD_POOL_METRICS;
public class RemoteStorageThreadPool extends ThreadPoolExecutor {
- private final Logger logger;
+ private final Logger logger =
LoggerFactory.getLogger(RemoteStorageThreadPool.class);
Review Comment:
Can you make this as static to avoid creating multiple logger instances as
we do not need any context for each instance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
