mjsax commented on code in PR #16093: URL: https://github.com/apache/kafka/pull/16093#discussion_r1687233849
########## streams/src/main/java/org/apache/kafka/streams/errors/internals/FailedProcessingException.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.errors.internals; + +import org.apache.kafka.common.KafkaException; + +/** + * {@link FailedProcessingException} is the top-level exception type generated by Kafka Streams, and indicates errors have + * occurred during a {@link org.apache.kafka.streams.processor.internals.ProcessorNode ProcessorNode's} processing. + */ +public class FailedProcessingException extends KafkaException { + private static final long serialVersionUID = 1L; + + public FailedProcessingException(final Throwable throwable) { Review Comment: Do we really want to catch `Throwable`? From my understanding, it's (1) not best practice, and (2) we only hand (correctly IMHO) `Exception` into the new handler, so if we would really have a `Throwable` at hand, we could not pass it into the handler anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
