chia7712 commented on code in PR #16200:
URL: https://github.com/apache/kafka/pull/16200#discussion_r1689639268


##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##########
@@ -360,57 +371,68 @@ public void testNoCoordinator() {
     @ParameterizedTest
     @ApiKeyVersionsSource(apiKey = ApiKeys.CONSUMER_GROUP_HEARTBEAT)
     public void testValidateConsumerGroupHeartbeatRequest(final short version) 
{
+        heartbeatState = new HeartbeatState(

Review Comment:
   I guess those creations can be moved to a helper to be shared by 
`testValidateConsumerGroupHeartbeatRequestAssignmentSentWhenLocalEpochChanges`, 
`testValidateConsumerGroupHeartbeatRequest` and 
`testFirstHeartbeatIncludesRequiredInfoToJoinGroupAndGetAssignments`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to