mingyen066 commented on code in PR #16680:
URL: https://github.com/apache/kafka/pull/16680#discussion_r1691215301
##########
clients/src/main/java/org/apache/kafka/clients/ClusterConnectionStates.java:
##########
@@ -42,7 +42,7 @@ final class ClusterConnectionStates {
static final int CONNECTION_SETUP_TIMEOUT_EXP_BASE = 2;
static final double CONNECTION_SETUP_TIMEOUT_JITTER = 0.2;
private final Map<String, NodeConnectionState> nodeState;
- private final Logger log;
+ private static final Logger log;
Review Comment:
Thanks for finding the bug. This is the case that I shouldn't change the
logger to static.
I have re-evaluated and used a different approach. I have completed the code
updates and written a new PR message that includes the methodology and criteria
used. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
