loicgreffier commented on PR #16684: URL: https://github.com/apache/kafka/pull/16684#issuecomment-2250417070
@cadonna So maybe the fix brought by this PR should be: 1. Checking in `ProcessorNode#process` if `rawRecord != null` before accessing the raw key and the raw value. It is the safest approach for me and will avoid crashing to NPE. The drawback is the processing exception handler can end up with no `sourceRawKey` nor `sourceRawValue` while the values are actually available in upstream. 2. Fix the source raw key and source raw value being null from store caches and buffers. The `recordContext()` needs to be accessed which currently fails some tests. Does it make sense? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
