FrankYang0529 commented on code in PR #15502:
URL: https://github.com/apache/kafka/pull/15502#discussion_r1691576823
##########
core/src/main/scala/kafka/network/RequestChannel.scala:
##########
@@ -258,7 +258,11 @@ object RequestChannel extends Logging {
m.responseSendTimeHist.update(Math.round(responseSendTimeMs))
m.totalTimeHist.update(Math.round(totalTimeMs))
m.requestBytesHist.update(sizeOfBodyInBytes)
-
m.messageConversionsTimeHist.foreach(_.update(Math.round(messageConversionsTimeMs)))
+ m.messageConversionsTimeHist.foreach(h => {
+ if (messageConversionsTimeMs > 0) {
Review Comment:
Hi @chia7712, we can leave `messageConversionsTimeHist` update as usually.
The `MessageConversionsTimeMs` is used when producer uses a older message
format than the broker. The test case is used to test old message format, so I
think we can just update the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
