mimaison commented on code in PR #16620:
URL: https://github.com/apache/kafka/pull/16620#discussion_r1692851169
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -374,13 +395,15 @@ class ControllerMutationQuotaTest extends BaseRequestTest
{
}
private def quotaMetric(user: String): Option[KafkaMetric] = {
- val metrics = servers.head.metrics
+ def metrics =
Review Comment:
This can be a `val`
##########
core/src/test/scala/unit/kafka/server/ControllerMutationQuotaTest.scala:
##########
@@ -364,7 +385,7 @@ class ControllerMutationQuotaTest extends BaseRequestTest {
}
private def waitUserQuota(user: String, expectedQuota: Double): Unit = {
- val quotaManager = servers.head.quotaManagers.controllerMutation
+ val quotaManager = brokers.head.quotaManagers.controllerMutation
Review Comment:
In KRaft mode should we check the QuotaManager on both `brokers.head` and
`controllerServers.head`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
