mjsax commented on code in PR #16433:
URL: https://github.com/apache/kafka/pull/16433#discussion_r1693449812
##########
streams/src/main/java/org/apache/kafka/streams/errors/ProductionExceptionHandler.java:
##########
@@ -30,22 +30,60 @@ public interface ProductionExceptionHandler extends
Configurable {
*
* @param record The record that failed to produce
* @param exception The exception that occurred during production
+ * @deprecated Use {@link #handle(ErrorHandlerContext, ProducerRecord,
Exception)} instead
*/
- ProductionExceptionHandlerResponse handle(final ProducerRecord<byte[],
byte[]> record,
- final Exception exception);
+ @Deprecated
+ default ProductionExceptionHandlerResponse handle(final
ProducerRecord<byte[], byte[]> record,
+ final Exception
exception) {
+ throw new UnsupportedOperationException();
Review Comment:
KIP says `NotImplementedException` -- we should update the KIP -- same for
the other method below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
