lianetm commented on code in PR #16715:
URL: https://github.com/apache/kafka/pull/16715#discussion_r1695486461


##########
tests/kafkatest/services/kafka/kafka.py:
##########
@@ -782,7 +782,8 @@ def prop_file(self, node):
 
         if self.use_new_coordinator:
             override_configs[config_property.NEW_GROUP_COORDINATOR_ENABLE] = 
'true'
-    
+            
override_configs[config_property.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG] 
= 'classic,consumer'

Review Comment:
   just to double check, here we're adding both as a default, but still 
respecting any specific value that a test may have right? (I guess the 
following logic on ln 788 ensures that?)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to