gharris1727 commented on PR #15598: URL: https://github.com/apache/kafka/pull/15598#issuecomment-2257077548
> One higher-level thought I had: is it better to keep all of this new logic in the existing Exit class, or would it make sense to separate the two? IMO the final state we work towards should still be a single Exit class, but in the meantime, it could ease the migration and reduce complexity to separate the static (legacy) exit logic and the non-static (end state) logic. Not a blocker though, just a shower thought. I implemented this originally as "SafeExit"and didn't like it, and I mentioned why in the PR description. It was a silly name, and cause import churn that didn't feel worth it. I do see where you're coming from, so I moved the instance methods up to the top of the class. This probably doesn't help javadoc users, but for source-code readers the instance methods should be more visible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
