loicgreffier commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1697004851
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -916,7 +920,17 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
} catch (final StreamsException e) {
Review Comment:
@mjsax
If `punctuate()` calls `context.forward()` and an exception occurs in a
processor I'm having doubts if the exception will either:
- Go up to the `try-catch` block we added around `punctuate()`
- Go up to the `try-catch` block we added around `ProcessorNode#process`
`Try-catch` block on `punctuate()` was initially added to handle exceptions
that can occurs in punctuator:
```java
context.schedule(Duration.ofMinutes(1), PunctuationType.WALL_CLOCK_TIME,
timestamp -> {
throw new RuntimeException("Punctuate error");
});
```
Doing further tests on this one..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
