chia7712 commented on code in PR #16661:
URL: https://github.com/apache/kafka/pull/16661#discussion_r1697346337
##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -654,4 +650,12 @@ private void waitForAllFutures(List<Entry<String,
Future<?>>> futureEntries)
log.debug("{} successfully shut down.", entry.getKey());
}
}
+
+ private void waitForAllThreads() {
Review Comment:
Using `TestUtils.waitForCondition` is ok but we should move it out of
`final` block. The infinite wait is not good in testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
