[
https://issues.apache.org/jira/browse/KAFKA-17215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869821#comment-17869821
]
Ksolves India Limited commented on KAFKA-17215:
-----------------------------------------------
[~mjsax] For now, we didn't get Confluence access. We'll follow up there.
In the meantime, we'll review the comments on attached PR & the POC one.
> Remove get-prefix for all getters
> ---------------------------------
>
> Key: KAFKA-17215
> URL: https://issues.apache.org/jira/browse/KAFKA-17215
> Project: Kafka
> Issue Type: Improvement
> Components: streams, streams-test-utils
> Reporter: Matthias J. Sax
> Priority: Minor
> Labels: needs-kip
>
> Kafka traditionally does not use a `get` prefix for getter methods. However,
> for multiple public interfaces, we don't follow this common pattern, but
> actually have a get-prefix.
> We might want to clean this up. The upcoming 4.0 release might be a good
> opportunity to deprecate existing methods and add them back with the
> "correct" name.
> We should maybe also do multiple smaller KIPs instead of just one big KIP. We
> do know of the following
> * StreamsConfig (getMainConsumerConfigs, getRestoreConsumerConfigs,
> getGlobalConsumerConfigs, getProducerConfigs, getAdminConfigs, getClientTags,
> getKafkaClientSupplier – for some of these, we might even consider to remove
> them; it's questionable if it makes sense to have them in the public API (cf
> [https://github.com/apache/kafka/pull/14548)] – we should also consider
> https://issues.apache.org/jira/browse/KAFKA-16945 for this work)
> * TopologyConfig (getTaskConfig)
> * KafkaClientSupplier (getAdmin, getProducer, getConsumer,
> getRestoreConsumer, getGlobalConsumer)
> * Contexts (maybe not worth it... we might deprecate the whole class soon):
> ** ProcessorContext (getStateStore)
> ** MockProcessorContext (getStateStore)
> ** MockProcessorContext#{color:#172b4d}CapturedPunctuator (getIntervalMs,
> getType, getPunctuator),{color}
> * api.ProcessingContext (getStateStore)
> ** api.FixedKeyProcessorContext (getStateStore)
> ** api.MockProcessorContext (getStateStore, getStateStoreContext)
> ** api.MockProcessorContext#{color:#172b4d}CapturedPunctuator (getInterval,
> getType, getPunctuator){color}
> * StateStore (getPosition)
>
> * IQv2: officially an evolving API (maybe we can rename in 4.0 directly w/o
> deprecation period, but might be nasty...)
> ** KeyQuery (getKey)
> ** Position (getTopics, getPartitionPositions)
> ** QueryResult (getExecutionInfo, getPosition, getFailureReason,
> getFailureMessage, getResult)
> ** RangeQuery (getLowerBound, getUpperBound)
> ** StateQueryRequest (getStoreName, getPositionBound, getQuery,
> getPartitions)
> ** StateQueryResult (getPartitionResults, getOnlyPartitionResult,
> getGlobalResult, getPosition)
> ** WindowKeyQuery (getKey, getTimeFrom, getTimeTo,
> ** WindowRangeQuery (getKey, getTimeFrom, getTimeTo)
>
> * TopologyTestDriver (getAllStateStores, getStateStore, getKeyValueStore,
> getTimestampedKeyValueStore, getVersionedKeyValueStore, getWindowStore,
> getTimestampedWindowStore, getSessionStore)
> * TestOutputTopic (getQueueSize)
> * TestRecord (getHeaders, getKey, getValue, getRecordTime)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
