chia7712 commented on code in PR #16717:
URL: https://github.com/apache/kafka/pull/16717#discussion_r1698808417
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1378,9 +1406,9 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
classOf[GroupNotEmptyException])
// Test delete one correct static member
- removeMembersResult =
client.removeMembersFromConsumerGroup(testGroupId, new
RemoveMembersFromConsumerGroupOptions(
- Collections.singleton(new MemberToRemove(testInstanceId1))
- ))
+ val removeOptions = new
RemoveMembersFromConsumerGroupOptions(Collections.singleton(new
MemberToRemove(testInstanceId1)))
+ removeOptions.reason("test remove")
Review Comment:
not sure how to verify it :(
##########
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##########
@@ -1296,6 +1296,14 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegrationTest {
matching.size == 1
}, s"Expected to be able to list $testGroupId")
+ TestUtils.waitUntilTrue(() => {
+ val options = new
ListConsumerGroupsOptions().withTypes(Set(GroupType.CLASSIC).asJava)
Review Comment:
Could you please add test of sending request with both filters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
