mjsax commented on code in PR #16300:
URL: https://github.com/apache/kafka/pull/16300#discussion_r1698975359
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java:
##########
@@ -917,8 +922,34 @@ public void punctuate(final ProcessorNode<?, ?, ?, ?> node,
maybeMeasureLatency(() -> node.punctuate(timestamp, punctuator),
time, punctuateLatencySensor);
} catch (final StreamsException e) {
throw e;
- } catch (final RuntimeException e) {
- throw new StreamsException(String.format("%sException caught while
punctuating processor '%s'", logPrefix, node.name()), e);
+ } catch (final Exception e) {
Review Comment:
Thanks. I disagree to @cadonna conclusion -- we should rather catch
`RuntimeException` everywhere (consistency yes, but the other way around).
I'll cover this on the other PR I did open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
