cmccabe commented on code in PR #16669:
URL: https://github.com/apache/kafka/pull/16669#discussion_r1700511990
##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -223,12 +172,20 @@ object StorageTool extends Logging {
action(storeTrue())
formatParser.addArgument("--release-version", "-r").
action(store()).
- help(s"A KRaft release version to use for the initial metadata.version.
The minimum is ${MetadataVersion.IBP_3_0_IV0}, the default is
${MetadataVersion.LATEST_PRODUCTION}")
+ help(s"The release version to use for the initial feature settings. The
minimum is " +
+ s"${MetadataVersion.IBP_3_0_IV0}; the default is
${MetadataVersion.LATEST_PRODUCTION}")
formatParser.addArgument("--feature", "-f").
- help("A feature upgrade we should perform, in feature=level format. For
example: `metadata.version=5`.").
- action(append());
-
- parser.parseArgsOrFail(args)
+ help("The setting to use for a specific feature, in feature=level
format. For example: `kraft.version=1`.").
+ action(append())
+ val reconfigurableQuorumOptions = formatParser.addMutuallyExclusiveGroup()
+ reconfigurableQuorumOptions.addArgument("--standalone", "-s").
+ help("Used to initialize a single-node quorum controller quorum.").
+ action(storeTrue())
+ reconfigurableQuorumOptions.addArgument("--initial-voters", "-I").
Review Comment:
`controller.quorum.voters` is a separate configuration (which I think you
said you wanted to deprecate eventually) so I think naming the flag the same
thing would be highly confusing!
> maybe we can name this flag --controller-quorum-initial-voters. What do
you think
I think that's too long. `--initial-voters` seems short and descriptive, so
to be honest I think we should stick with that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
