mjsax commented on code in PR #16761:
URL: https://github.com/apache/kafka/pull/16761#discussion_r1700881369
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamImplTest.java:
##########
@@ -1285,62 +1257,6 @@ public void
shouldNotAllowNullValueJoinerWithKeyOnLeftJoinWithGlobalTableWithNam
assertThat(exception.getMessage(), equalTo("joiner can't be null"));
}
- @SuppressWarnings({"unchecked", "deprecation"}) // specifically testing
the deprecated variant
- @Test
- public void testNumProcesses() {
Review Comment:
I think we should keep this keep, but just update it to remove `through()`.
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -93,7 +93,7 @@ public class StreamsResetter {
private static final String USAGE = "This tool helps to quickly reset an
application in order to reprocess "
+ "its data from scratch.\n"
+ "* This tool resets offsets of input topics to the earliest
available offset (by default), or to a specific defined position"
- + " and it skips to the end of intermediate topics (topics that
are input and output topics, e.g., used by deprecated through() method).\n"
+ + " and it skips to the end of intermediate topics (topics that
are input and output topics.\n"
Review Comment:
> and it skips to the end of intermediate topics (topics that are input and
output topics.
This part can be removed too -- w/o `through()` there is no such thing as
"intermediate topics" and longer.
##########
tools/src/main/java/org/apache/kafka/tools/StreamsResetter.java:
##########
@@ -584,8 +584,8 @@ public StreamsResetterOptions(String[] args) {
.ofType(String.class)
.withValuesSeparatedBy(',')
.describedAs("list");
- intermediateTopicsOption = parser.accepts("intermediate-topics",
"Comma-separated list of intermediate user topics (topics that are input and
output topics, "
- + "e.g., used in the deprecated through() method). For
these topics, the tool will skip to the end.")
+ intermediateTopicsOption = parser.accepts("intermediate-topics",
"Comma-separated list of intermediate user topics (topics that are input and
output topics). "
Review Comment:
I think, we can remove this options from the tool entirely... (Or would we
need to keep it as we did not really officially deprecate it... 🤔 -- curious to
hear what @ableegoldman @cadonna @lucasbru @bbejeck think...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
