kirktrue commented on code in PR #16686:
URL: https://github.com/apache/kafka/pull/16686#discussion_r1702414612
##########
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##########
@@ -911,4 +911,42 @@ class PlaintextConsumerTest extends BaseConsumerTest {
assertThrows(classOf[WakeupException], () =>
consumer.position(topicPartition, Duration.ofSeconds(100)))
}
+
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersConsumerGroupProtocolOnly"))
Review Comment:
I should mention that _on my machine_, the test consistently passes for both
the `CLASSIC` and `CONSUMER` group protocols. However, when the test suite was
run on the CI pipeline, the test failed for every run of the `CLASSIC` group
protocol. I spent the worse part of a day investigating to reproduce the
failure, but I couldn't. Frustrated, I threw up my hands and update the test
parameters to only run the `CONSUMER` group protocol. So it's hard to know if
any of my changes work until they're run on CloudBees 🐝
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
