brandboat commented on code in PR #16783:
URL: https://github.com/apache/kafka/pull/16783#discussion_r1703000636
##########
clients/src/main/java/org/apache/kafka/clients/admin/OffsetSpec.java:
##########
@@ -73,18 +73,20 @@ public static OffsetSpec maxTimestamp() {
}
/**
- * Used to retrieve the offset with the local log start offset,
- * log start offset is the offset of a log above which reads are
guaranteed to be served
- * from the disk of the leader broker, when Tiered Storage is not enabled,
it behaves the same
- * as the earliest timestamp
+ * Used to retrieve the local log start offset.
+ * Local log start offset is the offset of a log above which reads
+ * are guaranteed to be served from the disk of the leader broker.
+ * <br/>
+ * Note: When tiered Storage is not enabled, it behaves the same as
retrieving the earliest timestamp offset.
*/
public static OffsetSpec earliestLocalSpec() {
return new EarliestLocalSpec();
}
/**
- * Used to retrieve the offset with the highest offset of data stored in
remote storage,
- * and when Tiered Storage is not enabled, we won't return any offset
(i.e. Unknown offset)
+ * Used to retrieve the highest offset of data stored in remote storage.
+ * <br/>
+ * Note: When tiered storage is not enabled, we will return unknown offset.
Review Comment:
this is included in
https://github.com/apache/kafka/pull/16783/files/b6426e51d40e5b921f7d497bb0f1c3b2b88adf68#diff-8c7debdc8479f762a5a9585de62d3254c10768249bddd45391b49ba5683526e4R363-R367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
