C0urante commented on PR #16567: URL: https://github.com/apache/kafka/pull/16567#issuecomment-2267583505
Thanks for taking a look @kirktrue. I don't believe synchronization is necessary. We set `closing` to `true` before making any attempt to leave the group, which guarantees that either the [LeaveGroup request we send as part of graceful shutdown](https://github.com/apache/kafka/blob/7c539f902983a76f14d0cd993e7d6dcbfdacd909/clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java#L1132) contains a member ID (if one was already assigned), or any member ID assignments for pending JoinGroup requests that are received after we send that initial LeaveGroup request will cause their own LeaveGroup request to be sent (due to the new logic introduced in this PR). Are there any edge cases you have in mind that could still cause issues here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
