brandboat commented on PR #16789: URL: https://github.com/apache/kafka/pull/16789#issuecomment-2268139439
> The total supports of 0.8 and 0.9 are not dropped. At least, we expect the producer should work. Hence, I prefer to solution 2 - make PushHttpMetricsReporter work with 0.8 > > PushHttpMetricsReporter use the time to get current time, and hence we can do a bit refactor for it. For example: PushHttpMetricsReporter can implement the Time to offer the current time. Thanks for the suggestion, I've addressed everything you mentioned, could you take another look ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
