kamalcph commented on code in PR #16765:
URL: https://github.com/apache/kafka/pull/16765#discussion_r1703690275
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -4203,13 +4270,51 @@ class UnifiedLogTest {
}
assertEquals(5, log.logSegments.size)
log.updateHighWatermark(log.logEndOffset)
+ // simulate calls to upload 3 segments to remote storage
Review Comment:
```suggestion
// simulate calls to upload 2 segments to remote storage
```
##########
core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala:
##########
@@ -4203,13 +4270,51 @@ class UnifiedLogTest {
}
assertEquals(5, log.logSegments.size)
log.updateHighWatermark(log.logEndOffset)
+ // simulate calls to upload 3 segments to remote storage
+ log.updateHighestOffsetInRemoteStorage(20)
+
+ log.deleteOldSegments()
+ assertEquals(3, log.logSegments.size())
+ assertEquals(0, log.logStartOffset)
+ assertEquals(21, log.localLogStartOffset())
+
// simulate calls to upload 3 segments to remote storage
Review Comment:
```suggestion
// simulate calls to upload the 3rd segment to remote storage
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
