jlprat commented on PR #16782: URL: https://github.com/apache/kafka/pull/16782#issuecomment-2268589351
One small note about this change, the class `CompressionType` is not meant to be a public one, right? It's not i nthe Javadoc, but package-wise it might feel like it's public. A quick search on GH shows some usages of this class (that are not coming from forks of Kafka): https://github.com/search?q=org.apache.kafka.common.record.CompressionType&type=code If it's public, we the changes made are source-compatible, but not binary-compatible. What this means is that if there is any library that needs this class, it would need to be recompiled in order to work with newer versions (as opposed to binary-compatible where no re-compilation is needed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
