C0urante commented on code in PR #16767:
URL: https://github.com/apache/kafka/pull/16767#discussion_r1704183897
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java:
##########
@@ -136,10 +137,14 @@ public List<Map<String, String>> taskConfigs(int
maxTasks) {
// if the replication is disabled, known consumer group is empty, or
checkpoint emission is
// disabled by setting 'emit.checkpoints.enabled' to false, the
interval of checkpoint emission
// will be negative and no 'MirrorCheckpointTask' will be created
- if (!config.enabled() || knownConsumerGroups.isEmpty()
- || config.emitCheckpointsInterval().isNegative()) {
+ if (!config.enabled() ||
config.emitCheckpointsInterval().isNegative()) {
return Collections.emptyList();
+ } else if (knownConsumerGroups.isEmpty()) {
Review Comment:
Also, maybe we can move lines 96 and 97 into `loadInitialConsumerGroups` so
that they don't get printed during `start` if we haven't completed the initial
load yet? Maybe we could also print something in `start` like "Initial consumer
load has not yet completed".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
