[ 
https://issues.apache.org/jira/browse/KAFKA-15875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17871257#comment-17871257
 ] 

Josep Prat commented on KAFKA-15875:
------------------------------------

Closed the old PR, opened a new one: https://github.com/apache/kafka/pull/16807

> Snapshot class is package protected but returned in public methods
> ------------------------------------------------------------------
>
>                 Key: KAFKA-15875
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15875
>             Project: Kafka
>          Issue Type: Task
>    Affects Versions: 3.6.0
>            Reporter: Josep Prat
>            Assignee: Josep Prat
>            Priority: Major
>              Labels: server-common
>
> org.apache.kafka.timeline.Snapshot class is package protected but it is part 
> of the public API of org.apache.kafka.timeline.SnapshotRegistry. This might 
> cause compilation errors if we ever try to assign the returned object of 
> these methods to a variable.
> org.apache.kafka.controller.OffsetControlManager is calling 
> SnapshotRegistry's methods that return a Snapshot and OffsetControlManager is 
> in another package.
>  
> The SnapshotRegistry class seems to not be public API so I don't think this 
> needs a KIP.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to