ShivsundarR commented on code in PR #16727:
URL: https://github.com/apache/kafka/pull/16727#discussion_r1705263060
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -259,6 +242,57 @@ private PollResult processAcknowledgements(long
currentTimeMs) {
return pollResult;
}
+ private Optional<UnsentRequest> maybeBuildRequest(AcknowledgeRequestState
acknowledgeRequestState, long currentTimeMs, boolean onCommitAsync) {
Review Comment:
Yeah so here, there are cases when if when we return `Optional.empty()`, the
`isAsyncDone` variable is set to `true` and cases when we set to `false`. So as
of now, we do need this variable, maybe if we have a separate map for
`commitAsyncs` and `commitSyncs` in a future PR, then we can get rid of this
variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
